Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS options for Express api-server module #1160

Closed
tassoman opened this issue Jul 22, 2022 · 1 comment
Closed

CORS options for Express api-server module #1160

tassoman opened this issue Jul 22, 2022 · 1 comment

Comments

@tassoman
Copy link

Is your feature request related to a problem? Please describe.
I'm trying to build a bot on localhost but using an external client for integration tests. The APIs module is blocking requests because of "cors" settings.

Describe the solution you'd like
I'd like to have a configuration option such as

"settings": {
  "api-server": {
    "cors": [ "*", "*.localdev", "*.example.com" ],
    "port": 3000
  }
}

Then let the library api-server understand to inject cors plugin into Express. Throwing an exception if cors npm module is missing asking to install.

Describe alternatives you've considered
Feature is discussed into #580 #815 but faded away 😴

Anyone interested?

@aigloss
Copy link
Collaborator

aigloss commented Nov 24, 2022

Closing due to inactivity. Please, re-open if you think the topic is still alive.

@aigloss aigloss closed this as completed Nov 24, 2022
@aigloss aigloss closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants