Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some random console.logs during execution - no option to switch logging off. #1202

Closed
ppedziwiatr opened this issue Nov 14, 2022 · 2 comments
Closed

Some random console.logs during execution - no option to switch logging off. #1202

ppedziwiatr opened this issue Nov 14, 2022 · 2 comments

Comments

@ppedziwiatr
Copy link

ppedziwiatr commented Nov 14, 2022 •
edited

Describe the bug
The library seems to console.log during the execution - with no option to switch off the logs completely.

To Reproduce

  1. Run the example https://github.com/axa-group/nlp.js#example-of-use
  2. A set of logs is being produced (without loggin level, time, etc - looks like console.log) - see 'screenshots'

Expected behavior
The library should not log anything to console by default. There should be an option to set the global logging level to sth like 'none'.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS
  • Package version: 4.24.0
  • Node version: 18.5

Additional context
The logger docs (https://github.com/axa-group/nlp.js/blob/master/docs/v4/logger.md) do not contain information about how to switch off the logging.
@jesus-seijas-sp
Copy link
Contributor

https://github.com/axa-group/nlp.js#log-training-progress

...
const manager = new NlpManager({ languages: ['en'], forceNER: true, nlu: { log: false }});
...

@ppedziwiatr
Copy link
Author

Thanks! Didn't spot this in the docs, my fault :-)

Though I believe it should be switched-off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesus-seijas-sp @ppedziwiatr